Repository navigation
fix(extension): explain debugger detach caused by foreign frames - #43815
Draft
microsoft-playwright-automation[bot] wants to merge 1 commit into
Draft
microsoft-playwright-automation[bot] wants to merge 1 commit into
microsoft-playwright-automation[bot] wants to merge 1 commit into
Conversation
Contributor
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Contributor
Test results for "tests 1"23630 passed, 705 skipped Merge workflow run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome detaches the debugger when another extension injects an extension-origin frame. Preserve that frame's URL as the page close reason, propagate it to client-side waiters, and stop swallowing closed-page failures while waiting for load. Handle an empty tab list without a secondary
TypeError, and document Chrome's restriction and the site-access workaround.The existing scheme-detach tests use one extension; this regression needs a second unpacked extension at browser launch, so it requires a separate test.
Verified the regression fails without the fix and passes with it, including a following navigation. All 43 extension tests, 14 MCP tab/snapshot-mode tests, page-close tests on all three engines, build, and flint pass.
Fixes #43230
Prepared by the triage workflow.