Repository navigation
test: follow the upstream rewrites of the tests with pending evaluate promises - #2027
Merged
Yury Semikhatsky (yury-s) merged 4 commits intoOct 29, 2026
Merged
Conversation
… promises Port the new versions of CA-011, EV-063, DD-019, RO-012, RO-013 and RO-100 from microsoft/playwright#43656 line by line, and drop the Java notes that explained how the old ports differed. TR-041 already matches.
Pavel Feldman (pavelfeldman)
approved these changes
Oct 28, 2026
Headless Chrome and Edge request /favicon.ico after a load and log the 404 as a console error, which got into the console messages of NA-085, RO-157 and other tests. Without the 404 the ports of TZ-006, CL-017 and CL-083 and the old click test can collect all messages, as upstream does.
The frame of a nested OOPIF gets its URL from its own session, together with its execution context. Reading the URL first could give "".
Yury Semikhatsky (yury-s)
merged commit Oct 29, 2026
c773834
into
microsoft:main
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/favicon.icowith 204 in the test servers. Headless Chrome and Edge request it after a load and log the 404 as a console error, which broke NA-085, RO-157 and the click tests.