Repository navigation
Optimizer: don't crash folding SplitToSequence with a dynamic scalar split - #3101
Open
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Open
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Kayvan Zahiri (Kayvan-Zahiri) wants to merge 1 commit into
Conversation
…split Signed-off-by: Kayvan Zahiri <kayvanandre@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizer.optimize()raises on the ONNX backend testtest_split_to_sequence_1, wheresplitis a scalar graph input:split_to_sequencein constant folding findssplit_shape == (), so it skips the 1-D branch, then readssplit_value.ndimwhilesplit_valueisNone:With a scalar split, the number of chunks depends on the split's value, so the folder can't rewrite the node without it. It now returns
Nonein that case, and the node is left as it is.The new test fails on main with the error above.
onnxscript/optimizertests: 76 passed.Found by running all ONNX 1.20 backend node test models through
optimizer.optimize()andrewriter.rewrite()and comparing onnxruntime outputs before and after, with Claude Code's help. Nothing else in that sweep came from onnxscript: the remaining differences were onnxruntime's own known failures (Resize align_corners, MaxUnpool with output_shape), where the folded result matches the expected outputs.