Repository navigation
Normalize GitHub Enterprise authentication endpoints to HTTPS - #493
Merged
Sheng Chen (jdneo) merged 5 commits intoOct 21, 2026
Merged
Conversation
Closed
Co-authored-by: jdneo <6193897+jdneo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix authentication redirection to github.com instead of ghe.com
Require HTTPS for GitHub Enterprise authentication endpoints
Oct 16, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sheng Chen (jdneo)
marked this pull request as ready for review
October 19, 2026 05:37
Sheng Chen (jdneo)
requested review from
Ethan Hou (ethanyhou) and
xinyi-gong
as code owners
October 19, 2026 05:37
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in this focused change; build and test execution remain unverified because the target-platform dependency repository was unreachable.
No open issues 🎉
What changed in this PR
Addresses #480 by rejecting invalid enterprise authentication endpoints in Eclipse preferences while preserving empty values for GitHub.com.
Changes:
- Require HTTPS URLs with a hostname.
- Add localized validation errors, placeholder text, and tooltips.
- Add regression tests for saved values, live validation, and native hints.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/messages.properties | Adds HTTPS guidance and validation text. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/Messages.java | Declares new localized message fields. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/GeneralPreferencesPage.java | Validates endpoints and displays native hints. |
| com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/preferences/GeneralPreferencesPageTest.java | Tests validation and value preservation. |
Review effort: Balanced
Accept hostnames and HTTP/HTTPS URLs, preview the resolved address, and share normalization across persistence and language server settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sheng Chen (jdneo)
changed the title
Member
Co-authored-by: jdneo <6193897+jdneo@users.noreply.github.com>
Sheng Chen (jdneo)
approved these changes
Oct 21, 2026
Ethan Hou (ethanyhou)
approved these changes
Oct 21, 2026
Sheng Chen (jdneo)
deleted the
copilot/fix-authentication-redirect-issue
branch
October 21, 2026 07:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server ignores HTTP enterprise authentication endpoints, which could leave sign-in directed to GitHub.com. Normalize supported input to HTTPS instead of requiring users to type the scheme themselves.
Local verification: UI Checkstyle passes, and all 26 normalization regression cases pass using the project's JUnit version. The targeted Maven compilation/UI test run is still blocked because the configured Wild Web Developer target-platform repository cannot be resolved from this environment.