Repository navigation
fix(envs): confine benchmark task output paths - #309
Open
Adong / 阿东玩 AI (adongwanai) wants to merge 1 commit into
Open
Adong / 阿东玩 AI (adongwanai) wants to merge 1 commit into
Adong / 阿东玩 AI (adongwanai) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the task-output confinement introduced in #264 to DocVQA, SearchQA, OfficeQA, and LiveMathematicianBench. The benchmark rollouts share one path resolver; safe identifiers keep their existing directory names, while LiveMath identifiers such as
202602:12map to stable directory segments that work on Windows.Slow-update trajectory reads use the same mapping and retain support for legacy POSIX LiveMath directories after checking containment. Regression tests cover rejected identifiers, symlink escapes, mapped rollout output, and both mapped and legacy trajectory reads.
Fixes #306.
Testing
python -m pytest -q tests/test_benchmark_task_output_paths.py tests/test_spreadsheetbench_task_id_confinement.py tests/test_slow_update_robustness.py— 34 passed.python -m pytest -q— 1,723 passed, 11 skipped, 359 subtests passed.uvx ruff check skillopt/envs/task_output.py skillopt/optimizer/slow_update.py tests/test_benchmark_task_output_paths.py— passed.git diff --check— passed.The test runs above were completed on October 7. Before submission, the October 8 check confirmed that upstream
mainremains at343db229dbd5ddaf9df6b1d5540d8bcdb2604d5cand that all eight changed files match the tested patch exactly.Existing Ruff findings in the full rollout files reproduce on the unchanged upstream baseline and are outside this change.