Repository navigation
Superseded: Support AssociatedEnum annotation on parameters and fields - #1855
Closed
Jevan Saks (jevansaks) wants to merge 4 commits into
Closed
Jevan Saks (jevansaks) wants to merge 4 commits into
Jevan Saks (jevansaks) wants to merge 4 commits into
Conversation
Resolve AssociatedEnum across metadata reference closures and preserve native storage through exact enum projection or explicit scalar conversion. Honor contextual return/output invalid-handle contracts without weakening typed borrowing safety. Add pinned baseline/metadata consumer matrices, unchanged callers, mutation controls, runtime ownership coverage and documented source-compatibility boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Compare value properties, exact enum fields and the existing UnscopedRef accessor pattern with unchanged interface and ref-field callers, including measured native layout and bit patterns. Retain the precise source break and safe explicit interface shim without changing the shipping projection. Record frozen OLD constructor HASTHIS limitations and audit a separately pinned unmigrated tooling control without accepting it as WinHttp NEW. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Project logical enum fields, pointers, buffers and signatures using native width and signedness. Preserve actual native enum ABI and existing scalar entry points. Compare unchanged synthetic-enum callers across all integral types and separate historical property regressions from migration acceptance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document the pinned migrated SDK comparison and four observed scheme-member source breaks. Require exact public and generated-text deltas, record member-name-only caller repairs separately, and include caller-mutation controls in the compatibility runner. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jevan Saks (jevansaks)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #1856, Support AssociatedEnum annotation on parameters and fields.
The replacement is a standalone draft from a branch in
microsoft/CsWin32targetingmain. It contains the focused AssociatedEnum implementation and omits the unrelated SafeHandle ownership changes and compatibility harness.Please review the replacement rather than this draft.