Repository navigation
Performance and style knowledge: compute Role Center headlines in the background; build client links with GetUrl - #225
Open
Michael Dieringer (MichaelDieringer) wants to merge 1 commit into
Conversation
…ent links with GetUrl Adds performance/compute-role-center-headlines-in-the-background and style/build-client-links-with-geturl with good/bad samples, cues in al-performance-review and al-style-review, and review-fixtures registrations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two articles, each with good and bad samples that compile.
performance/compute-role-center-headlines-in-the-backgroundHeadline RC …page that builds its text by looping over documents or entries should compute in anOnComputeHeadlinessubscriber on codeunit 1441"RC Headlines Executor". The result is stored per user and read on page open.OnIsAnyExtensionHeadlineVisibleonly ever setstrue, following Essential Business Headlines and the AL Guidelines (NAV Design Patterns) article.Headline RC A/P Adminloops on open.OnComputeHeadlines. The mechanism comes from BCApps source and the AL Guidelines pattern. That pattern's event locations are out of date, and the article says so.style/build-client-links-with-geturlGetUrl, not from a hardcoded host, tenant or environment combined with?company=/&page=. Learn saysGetUrlis based on server configuration and applies the tenant automatically.&filter=,&$filter=or&mode=appended to aGetUrlresultUseFiltersreturns an empty string when the current client type is not one of the listed types.Wiring
al-performance-review.al-style-review.Test plan
validate_frontmatter.py: 0 errors (2 warnings, both in files this PR doesn't touch)Test-KnowledgeIndex.ps1,Test-SkillIndex.ps1,Test-ReviewContract.ps1,Test-KnowledgeRetrieval.ps1Test-ReviewFixtures.ps1, including the-PrepareDirectorydeterministic ranking check🤖 Generated with Claude Code