Repository navigation
Fix AnalyzeTests strict-mode crash on mixed page scripting results - #2391
Merged
Merged
Conversation
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AnalyzeTests crash under strict mode when accessing failure property
Fix AnalyzeTests strict-mode crash on mixed page scripting results
Oct 6, 2026
Collaborator
|
Copilot resolve the merge conflicts in this pull request |
…sts-crash Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Contributor
Author
Maria Zhelezova (mazhelez)
marked this pull request as ready for review
October 9, 2026 12:43
Copilot started reviewing on behalf of
Maria Zhelezova (mazhelez)
October 9, 2026 12:44
View session
Collaborator
|
Copilot please move the release notes above the v10.0 section in a new "Issues" section. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted fix safely resolves the reported crash and includes comprehensive regression coverage.
0 open findings
What changed in this PR
Fixes strict-mode crashes when page scripting results contain both passed and failed tests.
Changes:
- Safely checks for
<failure>nodes before accessing failure details. - Adds regression coverage for mixed, skipped, all-passed, and all-failed results.
- Documents the fix in release notes.
| File | Description |
|---|---|
Actions/AnalyzeTests/TestResultAnalyzer.ps1 |
Guards failure-node access. |
Tests/AnalyzeTests.Test.ps1 |
Adds strict-mode regression tests. |
RELEASENOTES.md |
Documents issue #2390 resolution. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Contributor
Author
Alexander Holstrup (aholstrup1)
previously approved these changes
Oct 9, 2026
Collaborator
|
Copilot resolve the merge conflicts in this pull request |
…sts-crash Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Copilot
AI
dismissed
Alexander Holstrup (aholstrup1)’s stale review
via
October 9, 2026 13:51
751ba2b
Contributor
Author
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Maria Zhelezova (mazhelez)
approved these changes
Oct 9, 2026
Alexander Holstrup (aholstrup1)
approved these changes
Oct 9, 2026
Maria Zhelezova (mazhelez)
enabled auto-merge (squash)
October 9, 2026 14:26
ankosiorek
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
When a page scripting suite contains passed and failed tests, accessing
.failureon passed testcases throws under strict mode, masking the failure report.$testcase.SelectSingleNode('failure')before reading failure details.✅ Checklist