DroidGuard: Redact sensitive debug logging - #3813
Open
paulcakeface wants to merge 1 commit into
Open
paulcakeface wants to merge 1 commit into
paulcakeface wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redact potentially sensitive data currently emitted by DroidGuard debug logging.
This issue was identified while inspecting the DroidGuard authentication path during locked-bootloader Google Messages RCS testing for #2994.
The current logging can expose:
DroidGuardResultsRequestvaluesBuild.getSerial()results when availableSome ordinary ping diagnostics also generate artificial stack traces.
This change replaces those values with bounded status messages while preserving useful stage, flow and failure diagnostics.
Changes
There are no changes to DroidGuard request construction, snapshot contents, network payloads, return values, authentication behaviour or control flow.
Validation
The branch is based directly on current upstream
master:4c74e5acb79479004428be755547432294639878Exact validated commit:
8587365f9cde02f17ee4b7ea4c0453a9b98c3567GitHub Actions validation completed successfully:
git diff --checkalso passes.The resulting commit changes five DroidGuard source files with 11 additions and 12 deletions.
No physical-device testing was required or performed because this change only alters diagnostic logging.
RCS / #2994 context
The logging issue was found during investigation of the DroidGuard authentication path used by the ongoing Google Messages RCS work.
This PR is a standalone logging/privacy cleanup and does not claim to resolve #2994 itself.
It is submitted separately so the privacy cleanup can be reviewed independently from the larger RCS implementation work.
Related: #2994, #3812