Skip to content

add option to switch UEFI boot to snponly #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gerrit91 merged 3 commits into from
Sep 25, 2026
Merged

add option to switch UEFI boot to snponly #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b28d4e8
fix: switch UEFI boot to snponly
mwennrich Jul 23, 2026
000ccf7
Merge branch 'main' into use-snponly
mwennrich Sep 23, 2026
e883bda
add feature flag --ipxe-type=snponly
mwennrich Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,15 @@ ipxe:
)
cp ipxe/branding.h ipxe/ipxe/src/config/local/branding.h
(cd ipxe/ipxe/src &&\
make bin/ipxe.pxe bin/undionly.kpxe bin-x86_64-efi/ipxe.efi bin-i386-efi/ipxe.efi EMBED=../../../pixiecore/boot.ipxe)
make bin/ipxe.pxe bin/undionly.kpxe \
bin-x86_64-efi/ipxe.efi bin-i386-efi/ipxe.efi \
bin-x86_64-efi/snponly.efi bin-i386-efi/snponly.efi \
EMBED=../../../pixiecore/boot.ipxe)
(rm -rf ipxe/ipxe/bin && mkdir ipxe/ipxe/bin)
mv -f ipxe/ipxe/src/bin/ipxe.pxe ipxe/ipxe/bin/ipxe.pxe
mv -f ipxe/ipxe/src/bin/undionly.kpxe ipxe/ipxe/bin/undionly.kpxe
mv -f ipxe/ipxe/src/bin-x86_64-efi/ipxe.efi ipxe/ipxe/bin/ipxe-x86_64.efi
mv -f ipxe/ipxe/src/bin-i386-efi/ipxe.efi ipxe/ipxe/bin/ipxe-i386.efi
mv -f ipxe/ipxe/src/bin-x86_64-efi/snponly.efi ipxe/ipxe/bin/snponly-x86_64.efi
mv -f ipxe/ipxe/src/bin-i386-efi/snponly.efi ipxe/ipxe/bin/snponly-i386.efi
(cd ipxe/ipxe/src && make veryclean)
18 changes: 18 additions & 0 deletions pixiecore/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"maps"
"os"

"github.com/metal-stack/pixie/ipxe"
"github.com/metal-stack/pixie/pixiecore"
"github.com/spf13/cobra"
"github.com/spf13/viper"
Expand Down Expand Up @@ -69,6 +70,7 @@ func serverConfigFlags(cmd *cobra.Command) {
cmd.Flags().Int("metrics-port", 2113, "Metrics server port")
cmd.Flags().Int("status-port", 0, "HTTP port for status information (can be the same as --port)")
cmd.Flags().Bool("dhcp-no-bind", false, "Handle DHCP traffic without binding to the DHCP server port")
cmd.Flags().String("ipxe-type", "", "UEFI PXE build type to serve: ipxe or snponly")
cmd.Flags().String("ipxe-bios", "", "Path to an iPXE binary for BIOS/UNDI")
cmd.Flags().String("ipxe-ipxe", "", "Path to an iPXE binary for chainloading from another iPXE")
cmd.Flags().String("ipxe-efi32", "", "Path to an iPXE binary for 32-bit UEFI")
Expand Down Expand Up @@ -113,6 +115,10 @@ func serverFromFlags(cmd *cobra.Command) *pixiecore.Server {
if err != nil {
fatalf("Error reading flag: %s", err)
}
ipxeType, err := cmd.Flags().GetString("ipxe-type")
if err != nil {
fatalf("Error reading flag: %s", err)
}
ipxeBios, err := cmd.Flags().GetString("ipxe-bios")
if err != nil {
fatalf("Error reading flag: %s", err)
Expand Down Expand Up @@ -144,6 +150,18 @@ func serverFromFlags(cmd *cobra.Command) *pixiecore.Server {
DHCPNoBind: dhcpNoBind,
}
maps.Copy(ret.Ipxe, Ipxe)
switch ipxeType {
case "", "ipxe":
ret.Ipxe[pixiecore.FirmwareEFI32] = ipxe.MustGet("ipxe-i386.efi")
ret.Ipxe[pixiecore.FirmwareEFI64] = ipxe.MustGet("ipxe-x86_64.efi")
ret.Ipxe[pixiecore.FirmwareEFIBC] = ipxe.MustGet("ipxe-x86_64.efi")
case "snponly":
ret.Ipxe[pixiecore.FirmwareEFI32] = ipxe.MustGet("snponly-i386.efi")
ret.Ipxe[pixiecore.FirmwareEFI64] = ipxe.MustGet("snponly-x86_64.efi")
ret.Ipxe[pixiecore.FirmwareEFIBC] = ipxe.MustGet("snponly-x86_64.efi")
default:
fatalf("unsupported pxe type %q: must be one of: ipxe, snponly", ipxeType)
}
if ipxeBios != "" {
ret.Ipxe[pixiecore.FirmwareX86PC] = mustFile(ipxeBios)
}
Expand Down
Loading