Repository navigation
[Nexthop][bugfix] Clear stale CPLD sysfs attrs before create on platform_manager restart - #1695
Open
andrew-nexthop wants to merge 1 commit into
Open
andrew-nexthop wants to merge 1 commit into
andrew-nexthop wants to merge 1 commit into
Conversation
…ger restart Signed-off-by: andrew-nexthop <andrew@nexthop.ai>
andrew-nexthop
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Restarting platform_manager leaves the previous run's dynamic CPLD sysfs attributes in place (fbcpld_generic driver state outlives the restart), so every CREATE ioctl logs "attr ... already exists" kernel errors. Issue
FBCPLD_IOC_SYSFS_DESTROY_ALLbefore CREATE in createCpldSysfsAttrs so restarts are clean and idempotent, including after an unclean shutdown.Test Plan
FBCPLD_IOC_SYSFS_DESTROY_ALLon the live device removes all dynamic attrs and leaves the static fw_ver untouched.