Repository navigation
Conversation
Summary: A clean `cargo build` raises four warnings: - `hash_set_impl` only contains trait impls, so the `pub use hash_set_impl::*;` re-export brings in no names and triggers `unused_imports`. The `mod` declaration is kept so the impls stay in the crate. - `PatriciaTree::iter` and the two `ReverseGraph::rev` signatures elide a lifetime on `&self` while hiding it in the return type, which triggers `mismatched_lifetime_syntaxes`. Spell the hidden lifetime as `'_`. No behavior change; `cargo build --all-targets` is now warning free and all tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A clean
cargo buildraises four warnings:hash_set_implonly contains trait impls, so thepub use hash_set_impl::*;re-export brings in no names and triggersunused_imports. Themoddeclaration is kept so the impls stay in the crate.PatriciaTree::iterand the twoReverseGraph::revsignatures elide a lifetime on&selfwhile hiding it in the return type, which triggersmismatched_lifetime_syntaxes. Spell the hidden lifetime as'_.No behavior change;
cargo build --all-targetsis now warning free and all tests pass.