Repository navigation
Fix BGP GitHub CI by building in the FBOSS image - #16
Closed
KevinYakar wants to merge 1 commit into
Closed
KevinYakar wants to merge 1 commit into
KevinYakar wants to merge 1 commit into
Conversation
Summary: The BGP GitHub Actions workflow has failed on every run since it was added in July. It runs getdeps directly on an Ubuntu runner, where this dependency closure has never been built: it first fails to resolve the EL9-only `gcc12`, and past that, third-party code fails to compile under GCC 13. Build in the FBOSS CentOS Stream 9 image through `run-getdeps.py` instead, the environment the `oss_bgp` conveyor and on-diff BGP OSS jobs already build in, so GitHub CI checks the same thing internal CI does. Differential Revision: D128415158
meta-cla
Bot
added
the
CLA Signed
|
@KevinYakar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128415158. |
|
This pull request has been merged in 2f54d69. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The BGP GitHub Actions workflow has failed on every run since it was added in July. It runs getdeps directly on an Ubuntu runner, where this dependency closure has never been built: it first fails to resolve the EL9-only
gcc12, and past that, third-party code fails to compile under GCC 13.Build in the FBOSS CentOS Stream 9 image through
run-getdeps.pyinstead, the environment theoss_bgpconveyor and on-diff BGP OSS jobs already build in, so GitHub CI checks the same thing internal CI does.Differential Revision: D128415158