Repository navigation
Android: add hardware keyboard commands and BrailleSense 7 alternatives - #33
Open
edenkizerccr-coder wants to merge 13 commits into
Open
edenkizerccr-coder wants to merge 13 commits into
edenkizerccr-coder wants to merge 13 commits into
Conversation
Retain Control+Shift commands alongside layered alternatives and document the contributor’s reported BrailleSense 7 results. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Accept full and release-only input, preserve writer editing and post focus, and provide both Control+Shift and layered alternatives. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Part of the Android hardware keyboard and BrailleSense 7 contribution. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android users can operate timeline and post actions with Control shortcuts, including layered alternatives for devices that do not deliver Control+Shift reliably. This contributes the keyboard and reading improvements developed and tried in a separate private FastSMRW 0.6.1 copy, adapted to the official app's existing identity and services.
BrailleSense 7 testing reported by the contributor
Both the Control+Shift commands and their layered alternatives are retained. These are the contributor's physical-device reports from the private build, separate from automated checks; they do not claim exhaustive testing of every function or acceptance of the adapted official-app build on every device.
Changes
The official package, app name, version, signing configuration, update checks and Firebase notification route remain in place. No private-fork package/signing material, credentials, background polling dependency or APK is included. The shared C++ core and other platform front ends are unchanged; this is an Android input/accessibility binding for existing actions. BuildConfig generation is enabled for the diagnostic version label. The existing notification permission guard now explicitly catches SecurityException instead of runCatching so Android lint recognizes its handling; delivery semantics are retained.
Validation
Maintainer review points
Local position preservation intentionally takes priority over unsolicited core/server cursor selections after a local viewport exists. The current native select_row event has no reason field; an explicit synchronous jump-to-parent is allowed through a two-second same-timeline intent window. A shared event reason would allow a cleaner distinction between deliberate navigation and server-marker restores. This behavior needs maintainer review, especially with home position synchronization enabled.
The saved anchor must still be available for exact restoration, and this does not restore a particular word or braille cursor within a post. Editor source fetching still depends on the existing server/worker request; cancelling ignores the delayed editor rather than aborting that request. Testing with other Android keyboards and screen readers remains welcome.