Repository navigation
fix: accept string transaction errors in Solana RPC models - #3
Open
ClancyBreach wants to merge 1 commit into
Open
ClancyBreach wants to merge 1 commit into
ClancyBreach wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solana RPC transaction errors can be strings (for example,
"BlockhashNotFound"), structured objects, ornull. The models currently accept only objects ornull, so valid string errors raise a Pydantic validation error instead of being returned to the caller.On the current
main, this reproduces the problem:Extend
errtostr | dict | NoneinSignatureStatus,TransactionSignature,TransactionMetadata, andTransactionSignaturesDetail, matching the documented Solana transaction-error forms. Existing object/null values remain supported, and the field remains required.Add 40 parametrized regression cases covering all four models and their client parsing paths, successful responses, string/object errors, invalid primitive values, and missing fields. HTTP responses are simulated with respx using synthetic fixtures based on documented RPC response shapes.
Validation on Python 3.11.9:
src/helius/laserstream/websockets.py.No public SDK methods or dependencies are changed. No live RPC requests or blockchain transactions were used.