Skip to content

feat(notch-hover-panel): morph the panel from the Dynamic Island - #542

Open
nikoelt wants to merge 7 commits into
mactools-app:mainfrom
nikoelt:spotlight-style-notch
Open

nikoelt wants to merge 7 commits into
mactools-app:mainfrom
nikoelt:spotlight-style-notch

Conversation

@nikoelt

@nikoelt nikoelt commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem and result

The Dynamic Island Hover Panel currently opens a separate panel below the notch. This change keeps hover to open and lets the panel expand from the notch as a single shape, similar to Spotlight. It closes back into the notch when the pointer leaves, and moving back during dismissal reverses the animation.

Closes #541.

Changes

  • Use a spring animation for the notch panel and respect the system Reduce Motion setting.
  • Keep the panel open when the pointer moves into it. Yield to the system Spotlight panel when it appears.
  • Keep the normal menu-bar popover on displays without a notch. Widen the hover panel as needed to place the controls on either side of the camera housing. On wide camera cutouts, bring the black surface flush with the top of the display.
  • Use direct notch hover by default. Side reach and lower reach remain configurable, and the lower-trigger toggle controls only the area below the notch. Saved preferences are preserved.
  • Add Panel style to the hover panel settings. Dynamic Island remains the default, and Classic restores the original slide-down popover.
  • Update the hover panel settings copy, guide, and changelogs.

Verification

  • At a4fe094f, make -j2 ci passed with 3,265 XCTest cases passed, 6 skipped, and all 250 script tests passed. The frozen PluginKit v7 binary compatibility client passed.
  • After the review fixes and merging main, at 54702506: the full XCTest suite passes (3,338 tests, 0 failures; 6 skipped by upstream's own settings), and make script-tests passes (275 tooling tests). It includes new tests for the dismissal reason and the size kept while closing.
  • Checked by hand after the review fixes, on the camera island with macOS 27: after Escape the panel stays closed while the pointer moves on the island, and it opens again once the pointer leaves and returns. A size change during closing is covered by the tests only.
  • Both Dynamic Island and Classic passed on the newer MacBook Pro (macOS 27.2.1) and older 14-inch MacBook Pro (macOS 26.6.2). A right-click on the MacTools menu-bar item during hover dismissal reclaimed the same panel. The reclaimed panel stayed open when the pointer moved away and closed on an outside click.
  • On the older 14-inch MacBook Pro, the black surface reached the top edge around the 185 pt camera cutout with square upper corners. The tabs and actions flanked the camera area.

UI evidence

Dark captures from a4fe094f.

Hardware Dynamic Island Classic
Newer MacBook Pro Dynamic Island on the newer MacBook Pro Classic on the newer MacBook Pro
Older 14-inch MacBook Pro Square-top panel on the older 14-inch MacBook Pro Classic on the older 14-inch MacBook Pro

The comparison video shows the newer Mac at left and the older Mac at right, with Dynamic Island above Classic. Download the click handoff recording (MP4)

Checklist

  • Core behavior and relevant risks are verified using existing tests, focused additions, or manual checks; results or limitations are recorded.
  • UI evidence is attached where applicable; shared components, themes, localization, and accessibility are respected.
  • User-facing documentation and changelog fragments are updated when required.
  • Plugin metadata, runtime contracts, action policies, and minimum-host compatibility agree.
  • Licensing and third-party notices are complete; no credentials, local configuration, or unrelated generated files are included.

@nikoelt

nikoelt commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

I’ve pushed the review follow-up in a4fe094f.

  • The panel stays flush with the top of wide camera cutouts throughout the morph. Its top corners stay square, the header is centered on the housing, and Settings and More are separate icons aligned to the tab grid.
  • A click or shortcut during hover dismissal reopens and claims the panel in either style. It then follows normal click-open dismissal. A shortcut with the menu-bar icon hidden keeps the existing popover in place.
  • Edit Panel uses the selected panel width. The plugin summaries and generated website data now describe direct hover over the notch in all 12 languages.

make -j2 ci passed. XCTest reported 3,265 passed and 6 skipped. All 250 script checks passed, including generated website data validation. The frozen PluginKit v7 client also passed.

@ggbond268

Copy link
Copy Markdown
Collaborator

Thanks for the update! The layout looks good. I found two remaining issues worth fixing in the shared panel lifecycle:

  1. Explicit dismissal can be cancelled by pointer movement. After pressing Escape, moving the pointer within the notch trigger during the closing animation calls reopen(), bringing the panel back. Please distinguish explicit dismissal from hover dismissal, and only let hover reverse a close caused by the pointer leaving.

  2. Size updates during dismissal are lost. resize(to:) ignores updates while closing, but the presenter already records the new size. If plugin content changes height and the pointer returns before closing finishes, the panel reopens with its old bounds and can clip the content. Please retain the latest requested size and apply it when reopening, or resynchronize it from the presenter before expanding.

I reproduced both in isolated checks using the actual controller and panel classes. These affect the host panel and the plugin content displayed inside it.

nikoelt and others added 2 commits November 18, 2026 20:49
…osing

Escape, a click elsewhere or a system panel could be undone by moving the
pointer on the island while the panel closed, because any hover reopened
it. The panel now records why it closes: only a close because the pointer
left is reversed by hovering back, while a click or shortcut still claims
it. After a dismissal the hover owner opens the panel again only once the
pointer has left the trigger and come back.

A size requested while the panel was closing was dropped, so a panel that
reopened kept its old bounds and could clip its content. The latest size is
now kept and applied when it reopens.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nikoelt added a commit to nikoelt/MacTools that referenced this pull request Nov 18, 2026
… island-notifications

# Conflicts:
#	Plugins/NotchHoverPanel/Sources/NotchHoverPanelController.swift
#	Sources/App/NotchMenuBarPanel.swift
#	docs/plugins/preferences-backup-inventory.md
@nikoelt

nikoelt commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, both are fixed in 678090f:

  1. Explicit dismissal. The panel now records why it closes. Only a close caused by the pointer leaving can be reversed by hovering back: presentPanelBelowAnchor declines to reopen a panel closing for any other reason (Escape, a click elsewhere, a system panel). A menu-bar click or the panel shortcut still claims a closing panel, as before. After a dismissal the hover owner opens the panel again only once the pointer has left the trigger and come back, so it doesn't reappear as soon as the close finishes with the pointer still on the island.
  2. Size during dismissal. resize(to:) keeps the latest size requested while closing, and reopen() applies it before expanding, so a panel that reopens has its current bounds.

New tests: a pointer-left close can be reversed by hover and a dismissed one cannot (including a hover close that becomes explicit); a size requested while closing is applied on reopen; and in the controller, a dismissed panel stays closed while the pointer stays on the island and opens again after it leaves and returns. The existing test for returning during a hover dismissal still passes.

I also merged the current main into the branch; it merged cleanly. The full XCTest suite passes (3,338 tests, 0 failures; 6 skipped by upstream's own settings), and make script-tests passes.

@ggbond268

Copy link
Copy Markdown
Collaborator

Thanks for the update! The normal Escape-dismissal case now stays closed, and size changes during closing are correctly applied when reopening.

One edge case remains: move the pointer away to start closing, press Escape during that animation, then return to the notch before it finishes. Moving within the trigger after the close completes can still reopen the panel. The host correctly refuses to reverse the explicit close, but the hover controller still treats it as a pointer-only dismissal.

Please synchronize the explicit-dismissal state with the hover controller, or clear its pointer-close flag when the host refuses to reopen. The panel should then stay closed until the pointer leaves the trigger and enters again. A small regression test for this sequence would help; I reproduced it in an isolated controller test.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Make the notch hover panel morph open like Spotlight

2 participants