Repository navigation
Conversation
|
I’ve pushed the review follow-up in
|
|
Thanks for the update! The layout looks good. I found two remaining issues worth fixing in the shared panel lifecycle:
I reproduced both in isolated checks using the actual controller and panel classes. These affect the host panel and the plugin content displayed inside it. |
…osing Escape, a click elsewhere or a system panel could be undone by moving the pointer on the island while the panel closed, because any hover reopened it. The panel now records why it closes: only a close because the pointer left is reversed by hovering back, while a click or shortcut still claims it. After a dismissal the hover owner opens the panel again only once the pointer has left the trigger and come back. A size requested while the panel was closing was dropped, so a panel that reopened kept its old bounds and could clip its content. The latest size is now kept and applied when it reopens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… island-notifications # Conflicts: # Plugins/NotchHoverPanel/Sources/NotchHoverPanelController.swift # Sources/App/NotchMenuBarPanel.swift # docs/plugins/preferences-backup-inventory.md
|
Thanks, both are fixed in 678090f:
New tests: a pointer-left close can be reversed by hover and a dismissed one cannot (including a hover close that becomes explicit); a size requested while closing is applied on reopen; and in the controller, a dismissed panel stays closed while the pointer stays on the island and opens again after it leaves and returns. The existing test for returning during a hover dismissal still passes. I also merged the current |
|
Thanks for the update! The normal Escape-dismissal case now stays closed, and size changes during closing are correctly applied when reopening. One edge case remains: move the pointer away to start closing, press Escape during that animation, then return to the notch before it finishes. Moving within the trigger after the close completes can still reopen the panel. The host correctly refuses to reverse the explicit close, but the hover controller still treats it as a pointer-only dismissal. Please synchronize the explicit-dismissal state with the hover controller, or clear its pointer-close flag when the host refuses to reopen. The panel should then stay closed until the pointer leaves the trigger and enters again. A small regression test for this sequence would help; I reproduced it in an isolated controller test. |
Problem and result
The Dynamic Island Hover Panel currently opens a separate panel below the notch. This change keeps hover to open and lets the panel expand from the notch as a single shape, similar to Spotlight. It closes back into the notch when the pointer leaves, and moving back during dismissal reverses the animation.
Closes #541.
Changes
Verification
a4fe094f,make -j2 cipassed with 3,265 XCTest cases passed, 6 skipped, and all 250 script tests passed. The frozen PluginKit v7 binary compatibility client passed.main, at54702506: the full XCTest suite passes (3,338 tests, 0 failures; 6 skipped by upstream's own settings), andmake script-testspasses (275 tooling tests). It includes new tests for the dismissal reason and the size kept while closing.UI evidence
Dark captures from
a4fe094f.The comparison video shows the newer Mac at left and the older Mac at right, with Dynamic Island above Classic. Download the click handoff recording (MP4)
Checklist