Repository navigation
Resume hostless Simulator XCTest agents before waiting for results - #470
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469, the hostless follow-up to #460.
Hostless Simulator tests run the SDK's
Agents/xctestexecutable. Its path has no device UUID, so the app-container ownership check rejects it and the test request waits on a stopped, untraced agent. The hosted-app correction therefore does not resume this case.Test requests now recognize SDK agents whose kernel-reported working directory is the selected Simulator's
<UUID>/datadirectory. The existing stopped/untraced, debugger, PID/start-time, and request-lifetime checks still apply. Captured agents retain that test-only permission for cancellation cleanup. Normal app launches keep the app-container check.Validation on Xcode 27.2, macOS 27.0.1, iOS Simulator 27.2:
The new ownership regression failed before the predicate change.
swift test --disable-sandbox --filter 'NativeApplicationLaunchTests|NativeExecutionOperationsTests|NativeLaunchOwnershipTests|NativeDebuggerReadinessTests'now passes all 25 tests. Real stopped subprocess cases cover both app-container and SDK-agent paths, including resume, cancellation, debugger intent, wrong Simulator, and stale PID identity.A hostless copy of ProxyToolVerifierFixture reproduced the stopped agent on main. With this fix, both
RunSomeTestsandRunAllTestsreturn 1 passed without manual signals through the packaged host and HTTP proxy.Two selected tests in a real multi-project application workspace pass without manual signals. Its complete test plan returns 2,004 results: 2,002 passed, 1 skipped, 1 expected failure, 0 unexpected failures, and 0 not run. Both selected and full runs complete without manual process signals.
After the full test run, debugger-attached launch and immediate
process statussucceed. A fresh session also launches without a debugger, with the PID verified running and untraced before stopping it. Three application Preview cases render successfully: normal text, largest Dynamic Type, and a fixed 1024 × 768 layout, downsampled to 1500 × 1125. The images were visually checked. The application source remains unchanged.