Repository navigation
Restore direct Preview rendering on Xcode 27.2 - #467
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #461. On Xcode 27.2, the direct renderer cannot bind inlined Preview input getters and falls back to a failing XPC request. Read the already-decoded native storage, including its defaults, so supported previews reach rendering.
Update the contracts encountered after decoding: project-container invalidation, source lookup, translation-unit parsing, destination resolution, and the source-plan subscript getter. The current destination adapter uses the scene host's callable catalog API and Xcode's resolver, preserving its feature gate, destination choices, selection, and warning messages.
Return the selected Xcode's advertised output shape. Xcode 27.2 receives
snapshot.pathandsupportedOverrides; earlier schemas retain their existing fields. The Preview verifier can save either snapshot shape and compare the grouped metadata.Validation on Xcode 27.2 (27B48), macOS 27.0.1, Apple Silicon:
swift test --disable-sandbox --filter 'NativePreviewCorrectionTests|NativePreviewBuildTests|PreviewVerifierTests': 54 tests passed, covering decoded values/defaults, both invalidation signatures, and both response schemas.previews capture --case mac-fixed --backend headlessalso saved the current-schema snapshot, closed its workspace and client, and reported no cleanup errors.The macOS SwiftUI fixed-layout size mismatch is tracked separately in #466, a sub-issue of #305, with an independent fix in #468. This validation does not establish GUI pixel parity or repeat the original 81-case matrix.