Repository navigation
Fix headless RunProject launch resumption and completion - #455
Merged
Merged
Conversation
Separate a successful RunProject request from the matching native launch Operation so the app can keep running after the reply. Resume only stopped, untraced apps belonging to the launch simulator without a selected debugger, and retain stream and unrelated Operation draining.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headless
RunProjectcan leave a simulator app suspended and then wait for that app to exit before returning. This change resumes a stopped simulator app after the native launch action finishes and returns while the app remains running.Fixes #451
Fixes #452
The request cleanup receives the final native outcome. For a successful launch, execution tracking excludes only the Operation whose launch-session PID matches the result. The native stream, unrelated Operations, and failed or cancelled requests still drain before the workspace permit is released.
The resumption check requires a simulator destination, a matching simulator UUID in the local executable path, no selected debugger, a stopped and untraced process, and an unchanged process identity. Once the launch passes to the workspace, later cancellation of its completed request does not cancel that app.
Validation uses the repository's fixture on macOS 27.0.1 with Xcode 27.2 (27B48) and a dedicated iOS 27.2 simulator:
./scripts/check.shpasses, including the process tests../scripts/verify-proxy-target-boundaries.shandgit diff --checkpass.The fallback applies to successful
RunProjectcalls. Test-runner launch behavior is unchanged. Cancellation before the native launch action completes can still hang on unmodified v0.26.0 and on this branch. That existing failure is tracked in #454.