Repository navigation
docs: <test> takes no width or height - #469
Merged
Merged
Conversation
The testing docs, AGENTS.md and the basic template's tests showed <test width="…" height="…">. The Editor and CLI reject both attributes, and the test runner never used them: a test runs at the display size of the project.xml target. The examples taught kapa.ai and agents (through AGENTS.md) to write tests that fail validation. - docs/syntax/testing.mdx: the example is a plain <test>, and the page says where the size comes from - AGENTS.md (and its synced copies): the component-test example is a plain <test> - templates/basic/tests: README example and note, and test_theme_toggle.xml Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs and the templates showed
<test width="…" height="…">. The Editor and CLI reject both attributes, and the test runner never used them. As a result, kapa.ai recommended them, and agents copied them fromAGENTS.mdinto the tests they write (for example<test width="800" height="480">), and those tests failed validation.Changes
docs/syntax/testing.mdx: the example is a plain<test>. The page now says that<test>takes no attributes and that a test runs at the display size of theproject.xmltarget.templates/common/AGENTS.md: the component-test example is a plain<test>. The five project copies are synced.templates/basic/tests/README.md: the example is a plain<test>, and the note about canvas size now says that a test has no size of its own.templates/basic/tests/test_theme_toggle.xml: a plain<test>.Why the attributes go
widthandheighton<test>.stagingbriefly accepted them, and that is reverted in the Editor PR linked below.<test>element.project.xml.Editor change: https://github.com/lvgl-private/editor/pull/1718
🤖 Generated with Claude Code