Repository navigation
feat(uds_services)!: a session change prepares, or is refused, before its response - #94
Draft
FelicianoAngulo2 wants to merge 1 commit into
Draft
FelicianoAngulo2 wants to merge 1 commit into
FelicianoAngulo2 wants to merge 1 commit into
Conversation
… its response DiagnosticSessionControl gains a required async prepare, awaited once a change is admitted and before its positive response, and a required MAY_RESPOND_PENDING saying whether 0x78 answers while it runs. A refusal is the request's negative response, conditionsNotCorrect say. The session is still entered only on the positive response's confirmation, and a link closed while prepare runs drops it with nothing sent. UDSSVC_ARCH_0046 places the stage, and UDSSVC_ARCH_0033 says why the service carries the constant. Breaking: every implementation adds both, as the changelog shows. On the embedded probe text falls 1348 bytes and main's frame grows from 1552 to 3320 bytes. No future changes size (-Zprint-type-sizes), but LLVM now inlines the poll of Server::handle, a separate 2232-byte frame before, into main, and keeps serve's poll, 832 bytes, apart; the deepest call chain from main, summed over the image's call graph, falls from 5180 to 5084 bytes. The baseline records it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session change asks the application to prepare it before the positive response, and the application can refuse it or answer pending;
MAY_RESPOND_PENDINGbecomes required, so this is a breaking change for implementers ofDiagnosticSessionControl.Depends on #93.
Issue URL
Towards https://github.com/luminartech/halo/issues/5100
Testing
Run on this branch with the commits of the PRs below it, each commit alone and on the stack's top:
validate,governance, the Sphinx needs build, and prose (plain and CI's--strict crates/uds_c)cargo test --workspace --all-features; clippy on the host and forthumbv7em-none-eabihfjust embeddedbuilds on 1.91 for both targets and the size check (matches the baseline)cargo docwith-D warnings;pre-commit run --all-filesci.ymlandcargo package -p uds_c --no-verify