Repository navigation
feat(simple_doip): build an entity as a static, its discovery started later - #92
Draft
FelicianoAngulo2 wants to merge 1 commit into
Draft
FelicianoAngulo2 wants to merge 1 commit into
FelicianoAngulo2 wants to merge 1 commit into
Conversation
… later Entity::new_discovery_later is a const fn, so a target whose stack cannot hold an entity builds it as a static's initializer, and start_discovery starts its discovery once the interface has an address and the identity is known. Both constructors share one private const fn. Entity::new keeps its run-time slot table: built from a constant, the table is an image of every buffer in flash, 7 KB more text on the embedded probe. EntityAddress::new becomes a const fn.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entity can now be built as a static, with its vehicle discovery started once the sockets exist, so an embedded image keeps the entity out of a task's stack.
Issue URL
Towards https://github.com/luminartech/halo/issues/5100
Testing
Run on this branch with the commits of the PRs below it, each commit alone and on the stack's top:
validate,governance, the Sphinx needs build, and prose (plain and CI's--strict crates/uds_c)cargo test --workspace --all-features; clippy on the host and forthumbv7em-none-eabihfjust embeddedbuilds on 1.91 for both targets and the size check (matches the baseline)cargo docwith-D warnings;pre-commit run --all-filesci.ymlandcargo package -p uds_c --no-verify