Repository navigation
fix(android): apply dark theme to lite mode static maps - #107
Merged
Merged
Conversation
Lite mode ignores mapColorScheme, so static maps always rendered light. Apply a JSON style approximating MapColorScheme.DARK instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android static maps (lite mode) always rendered light: lite mode ignores
mapColorScheme. Whenthemeresolves to dark ('dark', or'system'in dark mode), lite maps now get a JSON style approximatingMapColorScheme.DARK(colors sampled from a live dark map), cleared in light. Follows system appearance changes live.mapColorSchemeisDarkThemehelper for the provider and the static placeholderoverrideUserInterfaceStyle), no changeType of Change
Test Plan
Bare example, Static Maps screen:
cmd uimode night yes/nowith maps mounted, maps switched live. Cold mount in dark also renders dark. Pixel-sampled colors match the style and the live map's dark palette.Screenshots / Videos
Checklist