Skip to content

fix(android): apply dark theme to lite mode static maps - #107

Merged
lodev09 merged 2 commits into
mainfrom
fix/android-static-dark-mode
Nov 9, 2026
Merged

lodev09 merged 2 commits into
mainfrom
fix/android-static-dark-mode

Conversation

@lodev09

@lodev09 lodev09 commented Nov 9, 2026

Copy link
Copy Markdown
Member

Summary

Android static maps (lite mode) always rendered light: lite mode ignores mapColorScheme. When theme resolves to dark ('dark', or 'system' in dark mode), lite maps now get a JSON style approximating MapColorScheme.DARK (colors sampled from a live dark map), cleared in light. Follows system appearance changes live.

  • Non-lite static fallback (> ~2046px) is unchanged and still uses mapColorScheme
  • Shared isDarkTheme helper for the provider and the static placeholder
  • iOS Google static maps were already fine (warmup map takes overrideUserInterfaceStyle), no change

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Test Plan

Bare example, Static Maps screen:

  • Android (Pixel 10 Pro XL emulator): toggled cmd uimode night yes/no with maps mounted, maps switched live. Cold mount in dark also renders dark. Pixel-sampled colors match the style and the live map's dark palette.
  • iOS (iPhone 17 Pro Max sim, Google provider): static maps render with Google's dark scheme in dark appearance.

Screenshots / Videos

Checklist

  • I tested on iOS
  • I tested on Android
  • I tested on Web
  • I updated the documentation (if needed)

Lite mode ignores mapColorScheme, so static maps always rendered light.
Apply a JSON style approximating MapColorScheme.DARK instead.
@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
lugg-maps Ready Ready Preview Nov 9, 2026 7:45pm UTC

Request Review

@lodev09
lodev09 merged commit a981c37 into main Nov 9, 2026
5 checks passed
@lodev09
lodev09 deleted the fix/android-static-dark-mode branch November 9, 2026 19:46

This branch was successfully deployed

1 active deployment
Preview — 922ac271 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant