feat: let a regression include other regressions - #269
Merged
Merged
Conversation
A regression's tests key only accepts test names, so a regression made of two smaller ones had to repeat both lists. The new regressions key names other regressions whose tests it also runs. Only their tests are taken, and the modes and options of the including regression apply to all of them. Signed-off-by: Martin Velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
nested_regressions
branch
from
October 5, 2026 12:43
c8c9137 to
8102bd8
Compare
hcallahan-lowrisc
approved these changes
Oct 5, 2026
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
Thanks @martin-velay, this all LGTM. The additional tests to cover this feature are useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
regressionskey to regressions, naming other regressions whose tests it also runs.A regression's
testsonly accepts test names, and an unknown key stops dvsim, so a regression made of two smaller ones has to repeat both lists. With this change a top-levelcombinedcan run aregresion_aand aregresion_btogether:Inclusion is transitive and a test reached twice runs once. Only the tests of an included regression are taken, which keeps the current rule that a regression's modes and options apply to every test it runs. Including a regression that runs all tests (no
testskey) runs all tests. A missing name or a cycle stops dvsim with an error. The key merges across files like the other list keys, so a cfg can add it to thesmokethat a common cfg declares.