Repository navigation
Port to zbus 6 - #610
Open
domenkozar wants to merge 3 commits into
Open
Port to zbus 6#610domenkozar wants to merge 3 commits into
domenkozar wants to merge 3 commits into
Conversation
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
domenkozar
commented
Oct 20, 2026
|
|
||
| [workspace.dependencies] | ||
| ashpd = { version = "0.13", default-features = false } | ||
| # Temporary until https://github.com/bilelmoussaoui/ashpd/pull/491 is released. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move oo7's D-Bus client, daemon, CLI, and portal to zbus 6. Together with the GVariant split already merged in #552, this removes the standalone
zvariant,zvariant_derive, andzbus_namespackages from the workspace lockfile.zbus::wiretypes,Variant/OwnedVariant, andas_variantadapters, retaining the existing Secret Service signatures and GNOME double-wrapped variant handling.tokioandasync-stdfeatures, mapping the latter tozbus/default-rt. Keepzgvariantfor keyring files and the PAM socket protocol.enumflags2dependency.Applications passing connections to oo7 must use zbus 6, available through
oo7::zbus.This depends on the ashpd zbus 6 migration: bilelmoussaoui/ashpd#491. To make the complete workspace buildable and testable, ashpd is temporarily pinned to a port backported onto its stable 0.13.13 APIs. Replace that Git pin with a released ashpd version and remove its
deny.tomlsource allowance before merging/releasing this change.Validation:
cargo check --workspace.cargo test -p oo7 -p oo7-daemon -p kwallet-parser --features oo7/schema: 248 passed, 2 ignored, including encrypted/plain peer-to-peer Secret Service tests, GNOME and Plasma prompts, signals, keyring fixtures, and PAM listener tests.-D warnings; client Clippy for async-std/native and Tokio/OpenSSL; async-std/OpenSSL check.cargo fmt --all --checkandgit diff --check.cargo-deny check bans licenses sources: all pass.cargo-audit0.22.2 reports zero vulnerabilities and zero advisory warnings against the current RustSec database. The locally installed cargo-deny 0.18.2 cannot parse CVSS 4 advisories, so its advisory check is covered separately by cargo-audit.Prepared with Codex.