Repository navigation
[New] v0.33.4: pool batch take, one-save give-back - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pool of many small coins is one large file rewritten whole on every change. A bstore gateway held 10,854 coins (19.7 MB), 9,492 of them refunds of lapsed bounties, and wrote about 35 MB a minute idle. Merging them needs to take hundreds of coins, and each Take saves the whole pool.
bwallet.Pool.TakeSmall(tip, below, n): up to n proven, spendable coins of fewer than below satoshis, smallest first, one save.bwallet.Pool.ReturnAll(outs): Return for many, one save, no duplicates.producer.Payer.TakeSmall(ctx, below, n): the same coins signed for as Take's are; a coin it cannot sign for goes back.Payer.GiveBackreturns its coins with one save.Tests: TestTakeSmallAndReturnAll, TestTakeSmallSignsAndGivesBack. make verify passes locally.