Repository navigation
build: disable MPTCP listeners by default - #527
Open
ziggie1984 wants to merge 1 commit into
Open
ziggie1984 wants to merge 1 commit into
ziggie1984 wants to merge 1 commit into
Conversation
djkazic
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Disable Go's automatic MPTCP listener support for
poold. Pool does notintentionally configure or depend on MPTCP, so this restores ordinary TCP
listeners while retaining an explicit operator opt-in through
GODEBUG=multipathtcp=1.Go 1.24 and newer enable MPTCP listeners by default on supported Linux kernels.
MPTCP is a prerequisite for the Linux use-after-free path discussed in
lightningnetwork/lnd#11455
and mitigated for lnd in
lightningnetwork/lnd#11456.
Existing binaries
Operators can apply the same mitigation immediately, without rebuilding, by
starting
pooldwithGODEBUG=multipathtcp=0and restarting it. A patched kernelis still required to fix the underlying kernel vulnerability; this change removes
the demonstrated MPTCP-listener prerequisite.
Validation
go mod tidy -diffgo test ./cmd/pooldmultipathtcp=0inpoold's effective Go defaults