Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repin the gateway shim to v0.7.2.
Both pins move together
uses: lightninglabs/gateway-action@a590b98(v0.7.1)254f0cb(v0.7.2)runtime_ref:2c05e70(gateway v0.7.1)abe5c3a(gateway v0.7.2)The v0.7.2 runtime needs the job token that
gateway-actionv0.7.2 passes, so these two pins must move in the same change: bumping onlyruntime_refwould make every command fail, and bumping onlyuses:would keep running the previous runtime.No trigger, input, permission, secret, event or timeout changes.
What v0.7.2 brings
/gatewaycommand is now checked against the commenter's permissions before the job installs Claude or touches the App key or Claude credentials. A command that isn't allowed loads nothing and mints no token. It gets no reply; the reason is in the workflow log (authorize/skipped)./gateway explainneeds a maintainer or the PR author. It used to be open to anyone on GitHub, and each explain is a Claude call.GATEWAY_EXPLAIN_COOLDOWN_SECONDSandGATEWAY_CHECK_COOLDOWN_SECONDSin the job'senvchange the windows (0turns a guard off).Optional: skip outsiders' comments
The gateway shim template now has a job
if:filter that skips/gatewaycomments from anyone who is neitherOWNER/MEMBER/COLLABORATORnor the PR author, so they don't start a runner. It isn't added here. Before adding it, check that every maintainer who uses/gatewayhas public org membership: a private member can show up asCONTRIBUTOR, and their commands would be skipped silently.