Repository navigation
Conversation
…s with documentation
…ions with documentation
…artesian product option
…tesian product option
…ude particle argument and cartesian product option
…nd cartesian product option
…kflows, examples, and tests
Copilot review has found some mistakes like wrong naming scheme and wrong function names in few of them Signed-off-by: Piotr Pich <ppich@student.agh.edu.pl>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #229. Supersedes #230 (same converter changes, rebased onto current
masterwithout the stale branch-62 merge history).Summary
Ports the remaining converter functions from libamtrack to
pyamtrack.converters, and makes every converter take an explicitparticleargument with an optionalcartesian_productflag.New converters
gamma_from_energy/energy_from_gammamomentum_from_energy/energy_from_momentumdose_from_fluence/fluence_from_doseenergy_per_amu_from_energy/energy_from_energy_per_amuChanged converters
beta_from_energy(energy_MeV, particle)andenergy_from_beta(beta, particle)now take a particle and total kinetic energy in MeV, instead of assuming MeV/u.Call sites
scripts/build_linux.sh,docs/naming_convention.md,examples/example.ipynb, and the tests (test_converters.py,test_function_behavior.py,test_multidim_input.py) to the new signatures.Testing
pip install .andpytest tests: 106 passed.