Skip to content

Refresh automation.yml from the shared template - #358

Merged
rtibbles merged 1 commit into
release-v0.9.xfrom
refresh-automation-template
Sep 21, 2026
Merged

rtibbles merged 1 commit into
release-v0.9.xfrom
refresh-automation-template

Conversation

@akolson

@akolson akolson commented Sep 21, 2026

Copy link
Copy Markdown
Member

The copy of automation.yml in this repo predates three fixes in learningequality/.github. This replaces it with the current automation-template.yml from main.

  • The blank line above name: is removed. yamlfmt v0.16.0 and later strip it, so a repo on a newer pin rewrites the file on its next pre-commit run.
  • on: carries # zizmor: ignore[dangerous-triggers]. zizmor reports pull_request_target as a dangerous trigger, and the callers this template replaced each carried the same inline ignore.
  • Event keys and type lists are sorted. Sorting keeps this file stable when an automation is toggled in the registry, so a seasonal change no longer reshuffles it.

No trigger changes. The event and activity type sets are identical, so every automation fires exactly as it does today.

@akolson
akolson requested a review from rtibblesbot September 21, 2026 15:56
@rtibblesbot

rtibblesbot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🟡 Waiting for changes

Last updated: 2026-09-21 16:00 UTC

@rtibblesbot rtibblesbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #358 is a pure regeneration. The file is byte-identical to learningequality/.github@main:automation-template.yml. The trigger set is unchanged: both issues and pull_request_target type lists hold the same entries, reordered. Reproduced the motivation locally. The pre-PR file is rewritten by the pinned yamlfmt v0.21.0. The post-PR file is stable under it. actionlint passes. CI is green. No UI files, so no visual verification or manual QA.

  • nitpick: drop the zizmor-ignore justification from the PR body — it doesn't hold for this repo. See the inline comment.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Ran a phased review pipeline over the pull request diff:

  • Classified the diff to select review passes (core, frontend, backend) and whether manual QA was required
  • Core review pass checked correctness, design, architecture, testing, completeness, and DRY/SRP/Rule-of-Three principles
  • Specialized frontend/backend review passes applied framework-specific lenses where those files changed
  • For UI changes: manual QA and an accessibility audit against a live dev server, when available
  • Checked CI status and linked issue acceptance criteria
  • Synthesized one review from those passes and chose the verdict from the findings, CI status, and QA evidence

- reopened
- edited
- review_request_removed
on: # zizmor: ignore[dangerous-triggers]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: The PR body's stated reason for keeping this zizmor ignore doesn't hold for morango. It says the callers this template replaced each carried the same inline ignore. morango's one such caller, call-pull-request-target.yml, had no zizmor comment in its on: block. zizmor isn't wired into this repo at all. Keep the line — byte-identity with the template justifies it on its own — but drop that claim from the PR body.

@rtibbles
rtibbles merged commit 9b56d64 into release-v0.9.x Sep 21, 2026
67 checks passed
@rtibbles
rtibbles deleted the refresh-automation-template branch September 21, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants