Repository navigation
refactor: use nested Pimpl for Tun, drop std::any - #499
Merged
Merged
Conversation
lanthora
commented
Aug 6, 2026
lanthora
commented
Owner
- Centralize inTunNetwork() in platform-agnostic tun.cc using getIP()/getMask()
- Replace std::any with unique_ptr; platform tun classes become Tun::Impl
- Keep ip/mask state in Tun, up() now takes (IP4 ip, IP4 mask)
- Rename shouldDrop() to invalidSrcDst(), allow broadcast/multicast
- Remove dead members (timeout, macos name)
lanthora
marked this pull request as ready for review
August 6, 2026 10:04
lanthora
force-pushed
the
refactor/tun-nested-pimpl
branch
from
August 6, 2026 10:06
6b58d1b to
9927cc8
Compare
- Centralize inTunNetwork() in platform-agnostic tun.cc using getIP()/getMask() - Replace std::any with unique_ptr<Impl>; platform tun classes become Tun::Impl - Keep ip/mask state in Tun, up() now takes (IP4 ip, IP4 mask) - Remove dead members (timeout, macos name)
lanthora
force-pushed
the
refactor/tun-nested-pimpl
branch
from
August 6, 2026 10:17
9927cc8 to
f28b12a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.