Repository navigation
Fix setSafeMode ignoring its argument - #29
Merged
Merged
Conversation
setSafeMode always set safeMode to true, so any client calling setSafeMode(false) still passed --no_include true to Kind 2 and had include statements rejected. Also default safeMode to null so that --no_include is omitted unless explicitly set, consistent with the other options. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Looks good. This was a silly mistake from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setSafeMode(boolean)always setsafeModetotrue, so callingsetSafeMode(false)still made the API pass--no_include trueto Kind 2. As a result, include statements were rejected even with safe mode off. The Kind 2 language server callssetSafeMode(safeMode)on every run, so include statements broke for every user, not only those withKIND2_SAFE_MODE=true.Changes:
setSafeModenow stores the argument it's given.safeModenow defaults tonullinstead offalse, so--no_includeis left off unless it's set explicitly. This matches the other options.🤖 Generated with Claude Code