Repository navigation
Preserve BTC signing refusals and verify legacy Hyperliquid fallback - #79
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BTC signing replaced device refusals and transport errors with a generic failure, hiding the reason for sends that stopped before an OLED prompt. Preserve the firmware error text and existing Error identity, including user cancellation, on both the initial request and subsequent acknowledgements.
Add a Hyperliquid ApproveAgent compatibility regression for firmware without streaming EIP-712. It verifies the existing legacy fallback against independently computed domain/message hashes and proves cancellation cannot trigger a downgrade. This is software coverage; the reported passphrase/device case still requires physical reproduction.
Validation: TypeScript build of hdwallet-core and hdwallet-keepkey passed; 16 focused Jest tests passed. Parent Desktop post-release work is being prepared against develop.