Repository navigation
Add classic Bitcoin multisig address and signing metadata - #78
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add classic Bitcoin multisig metadata to KeepKey address, input and change-output requests so Vault can verify a public policy and co-sign an imported PSBT. Preserve the caller’s derived-key order and existing bare DER signature slots; validate thresholds, public nodes and unhardened suffixes before USB encoding. Legacy multisig account xpub requests use SPENDADDRESS, as required by firmware.
Validation: 226 Jest tests across 23 suites passed, changed-file ESLint passed, and the core/KeepKey/USB adapter TypeScript builds passed. Physical KeepKey 7.16.0 matched four receive/change addresses and signed synthetic native, wrapped SegWit and legacy 2-of-3 transactions. Sparrow 2.1.2 and Electrum 4.8 independently verified the resulting signatures. No funded transactions were spent by these checks.
Required by the Vault multisig co-signing PR; Vault will expose that workflow only through a runtime Settings flag, default off.