Skip to content

feat(retention): add workflow execution and log cleanup maintenance script (#6942) #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
granbellllc-png wants to merge 3 commits into
base: main
Choose a base branch
from
+896 −2
Open

feat(retention): add workflow execution and log cleanup maintenance script (#6942) #6959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93ab9c7
fix(servicenow): safely parse result list and annotate return type in…
granbellllc-png Nov 11, 2026
528d9f4
feat(retention): add workflow execution and log cleanup maintenance s…
granbellllc-png Nov 11, 2026
db31adc
fix(retention): address review feedback on session sync, associations…
Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions keep/providers/servicenow_provider/servicenow_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def _get_headers(self):
headers["Authorization"] = f"Bearer {self._access_token}"
return headers

def validate_scopes(self):
def validate_scopes(self) -> dict[str, bool | str]:
"""
Validates that the user has the required scopes to use the provider.
"""
Expand Down Expand Up @@ -244,7 +244,13 @@ def validate_scopes(self):

if response.ok:
roles = response.json()
roles_names = [role.get("name") for role in roles.get("result")]
raw_result = roles.get("result") if isinstance(roles, dict) else []
result_list = raw_result if isinstance(raw_result, list) else []
roles_names = [
role.get("name")
for role in result_list
if isinstance(role, dict)
]
if "itil" in roles_names:
self.logger.info("User has ITIL role")
scopes = {
Expand Down
Loading
Loading