Repository navigation
Conversation
|
|
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
Author
|
I have read the CLA Document and I hereby sign the CLA |
granbellllc-png
force-pushed
the
fix/issue-6751-jiraonprem-preserve-priority-on-update
branch
from
November 11, 2026 07:56
1e01215 to
fbf1d1b
Compare
…ephq#6751) - Change default priority from 'Medium' to None in JiraonpremProvider._notify and __update_issue. - In _notify, when creating a new issue, default to 'Medium' (priority or 'Medium') to preserve issue creation defaults. - When updating an issue, only include priority in update payload when explicitly provided. - Add unit tests in tests/test_jira_provider.py asserting priority is preserved when unspecified and forwarded when specified.
granbellllc-png
force-pushed
the
fix/issue-6751-jiraonprem-preserve-priority-on-update
branch
from
November 11, 2026 08:10
fbf1d1b to
66a806c
Compare
Author
|
Hi team, CLA is signed and all CI checks are green (unit tests passing). Ready for review whenever you have time. Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6751.
Previously,
_notifyand__update_issuedefaultedpriorityto"Medium". When a workflow updated an issue (e.g. modifying the summary or custom fields without touching priority),__update_issuewroteupdate["priority"] = [{"set": {"name": "Medium"}}], silently resetting manually escalated tickets back to Medium.Changes
priorityparameter from"Medium"toNonein_notifyand__update_issue(keep/providers/jiraonprem_provider/jiraonprem_provider.py).__create_issue),_notifypassespriority or "Medium", preserving the default issue creation priority.__update_issueonly writesupdate["priority"]ifpriorityis explicitly provided.tests/test_jira_provider.pyasserting priority preservation when unspecified and priority update when specified.Testing
pytest tests/test_jira_provider.py->11 passed, 1 warning in 0.03s(Exit Code0).