Skip to content

fix(ui): keep theme previews unfaded in settings - #108

Merged
kbuffardi merged 2 commits into
mainfrom
fix/settings-drawer-unfaded-preview
Oct 9, 2026
Merged

kbuffardi merged 2 commits into
mainfrom
fix/settings-drawer-unfaded-preview

Conversation

@kbuffardi

Copy link
Copy Markdown
Owner

Summary

  • Keep the Settings click-outside layer transparent so the editor, terminal, and explorer retain their true theme colors while the drawer is open.
  • Remove the workspace-facing Settings drawer shadow while preserving the drawer border and all existing close/focus behavior.
  • Add source-level and Chrome smoke regression checks for the visual-preview contract.

Verification

  • npm run lint
  • npm run build
  • npm run test:e2e
  • npm run test:browser:chrome (passed in hosted fallback mode on Chrome 150)

Closes #106

Make the settings click-outside layer transparent and remove its workspace-facing shadow so theme previews remain true to the active palette.
Verify the live Settings flow keeps its click-outside target transparent and does not cast a shadow over workspace theme previews.
@kbuffardi
kbuffardi merged commit 209c1c2 into main Oct 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: light mode

1 participant