Repository navigation
feat: one-shot advisory cross-check - #537
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…indings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1a, T5 of the lean-mode scope (
docs/specs/lean-mode-scope.md§5, decisions O-2 and O-9 / Q-2 A).The operator must decide before merge: the shipped
crosscheck.ymlhassend_diff: false, and a project overlay accepts onlyproviders:. With the shipped defaults, every run therefore skips. That is correct behaviour, and the skip reason says so. The question is how a project opts in.Problem
Today's cross-check is a quorum vote that needs
min_providers: 2. In the 2026-11-03 trial, only codex was configured, so every close held. Each close also called codex twice, and one refute misread a check label.Change
New module
advisoryCrosscheck.ts, with two verbs.bs crosscheck runUsage:
bs crosscheck run --task --base --head [--criterion… | --criteria-file | --plan] [--test-file…]It always exits 0. Its status is one of
ok,skipped,failedordiscarded.independent_finder.providersorder that hasmode: active. Only listed vendors ever receive source. If none qualifies, the run is skipped and records why. The operator is never asked.maxBuffer = max_diff_bytes + 1. An oversize diff givesskipped/diff-too-large. Test files draw on the same byte budget, and any that are dropped are listed intest_files_dropped.runJudge,fingerprintWorktreeandcheckWorktreeImmutable. If the tree moves, the result is discarded and no findings are recorded.sent. Errors raised before any byte leaves giveskipped/sent: false. These aremissing-api-key,cli-unavailable,disabled,not-externalandunknown, each traced to the line that raises it. Anything after the send givesfailed/sent: true, includingauth-failedon a 401/403.envelopePreflightSweep.bs crosscheck reproduce <finding-id> --evidence <…>Blocking happens only on reproduction (Q-2 A).
raised.already_reproduced: true.refuted,fix-verifiedorexpired) is refused withcrosscheck.finding-closed.Isolation
Findings go to an
advisory-crosscheckevent asadvisory: true. Nojudge-verdictis written, and nothing reachesfinding-raisedbefore a reproduce. Quorum,epic close, provider-agreement stats,reportand the projection are unaffected. Tests pin this.Review
A fresh-context review ran three rounds, using fake transports only.
modeand the source allow-list;skipped;auth-failedafter a POST was recorded assent: false;All of these are fixed, each with a test written first and seen to fail.
Verification
heavy run: 276 files, 10924 passed.typecheck,typecheck:testand biome at error level: clean.🤖 Generated with Claude Code