Repository navigation
feat(windows): a Settings dialog from the tray and title-bar menu, and yserver's icon - #330
Merged
Merged
Conversation
…d the rooted window's system menu The dialog mirrors the macOS Settings window: the X display with Copy, mode, scale, clipboard sync and start at sign-in (the HKCU Run value), plus Restart, which starts yserver again with the same arguments. Live options apply at once, mode and scale at the next start. The settings are stored as key=value lines in %APPDATA%\yserver\settings.conf and apply under argv at every launch, so a launch without --rooted is now rootless by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
assets/yserver.ico (16 to 256 px, from yserver-icon.svg) is resource 1 of yserver.exe through yserver.rc and embed-resource on windows-msvc, and is loaded at the system's icon sizes for the window classes and the tray. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The window menu now opens only from the title bar, as before Settings; the keyboard's way into it is ignored. Scale is not shown until the process is DPI-aware, where it would change nothing; its stored value is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, yserver has a Settings dialog, like the macOS one, and uses its own icon instead of the generic Windows one.
Runregistry key).-authis kept.yserver.exenow starts rootless by default, as on macOS.--rootedand--rootlessoverride that for one run.%APPDATA%\yserver\settings.conf.assets/yserver.ico, made from the existing SVG, is embedded inyserver.exe, so Explorer and the taskbar show it. The tray and both window types use it.Verification:
Runkey quotes its command line. The quoting test vectors were checked against Windows' ownCommandLineToArgvW.Runvalue and removes it again;xevreceives Alt+Space, F10 and a lone Alt.🤖 Generated with Claude Code