Repository navigation
Encapsulate payload size pre-flight in the payload reader (#153) - #154
Merged
Merged
Conversation
readAndValidatePayload now takes ReadPayloadOptions { maxBytes, contentLength }
and throws PayloadTooLargeError for both declared and streamed overflow. The
enqueue route passes the header through instead of building its own 413.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ght check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
The enqueue route used to parse
Content-Lengthand build its own 413 response. The payload reader enforced the streamed limit on its own. NowreadAndValidatePayloadhandles both.readAndValidatePayload(stream, options)takesReadPayloadOptions { maxBytes?, contentLength? }. It throwsPayloadTooLargeErrorbefore reading the body when the declared length is over the limit.PayloadTooLargeError→ 413Payload too largemapping.parseInt, so the pre-flight rule is unchanged.Tests:
"5","not-a-number",""andnulllengths.Content-Length: 1048576is accepted.Content-Lengthwith a tiny body gets 413, an oversized chunked stream gets 413, and an exactly 1 MiB body gets 200.🤖 Generated with Claude Code