Repository navigation
Move srcset generation from Twig to Resolver - #173
Merged
Merged
Conversation
xavierlacot
force-pushed
the
feature/81-srcset-builder
branch
from
September 25, 2026 10:40
cbe476e to
07503f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #81
This PR moves the
srcsetgeneration from the Twig components into a newSrcsetBuilderservice, so it can also be used outside of Twig, for instance in an API Platform normalizer. It is also exposed through a newjoli_media_srcsetTwig filter.The
joli:Imgcomponent now builds thesrcsetof a variation configured with severalpixel_ratiosfrom its name alone, instead of requiring the derived variations to be listed by hand. This can be disabled withautoSrcset="{{ false }}".When a variation has not been generated yet, its dimensions are now computed from the variation definition, so the
srcsetkeeps itswidthdescriptors and theimgtag itswidthandheight, even on a cold cache. Pre-processors declare whether they preserve the pixel dimensions with the newPreProcessorInterface::preservesPixelDimensions()method.Also, the Twig components now read the dimensions from the cached property accessors instead of loading the whole variation file, and the properties of a missing file are no longer cached for a whole day.