Repository navigation
Add pathlib-compatible recursive globbing - #278
Open
zhou-jianwen wants to merge 1 commit into
Open
zhou-jianwen wants to merge 1 commit into
zhou-jianwen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Path.rglob(pattern)for recursive path discovery, addressing therglobitem in #214.Delegate matching to the host platform's
pathlib.Path.rgloband lazily convert results through the captured_next_class. This preserves ordinary subclasses andTempDir's conversion toPath. Document hidden-entry matching, host case/separator semantics and the distinction between recursive directory-symlink traversal and an explicitly named symlink segment. Existingglobandiglobbehavior is unchanged; their documentation points to the new method.Validation:
TempDiruse, custom-module host semantics and directory symlinks.sphinxlintpass. The Towncrier draft includes the new fragment with Maximize compatibility withpathlib.Path#214;NEWS.rstis unchanged.git diff --checkpasses.Local verification was on macOS arm64; hosted platform checks remain to be run.
AI assistance: OpenAI Codex was used for implementation, tests and automated review.