Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.readlink()strips the Windows extended path prefix from every target. Whenos.readlink()returns an extended UNC target, this leavesUNC\server\share\file, a relative path, instead of the network path\\server\share\file.Handle the extended UNC prefix before the existing drive-path normalization. Add regression coverage for extended UNC paths and unchanged drive-prefixed, ordinary UNC and relative paths, plus a news fragment.
Validation: the UNC regression fails on the base.
toxpasses with 168 tests, one skip and 99% coverage; baseline was 164 tests and one skip. Ruff lint/format checks pass. Tests simulate the documented Windowsos.readlink()output on macOS; native Windows execution has not been run locally.Found and implemented with Codex during a code audit; the reproduction and checks were run locally.