Repository navigation
Python template: install dev tools with uv sync and keep the venv on PATH - #156
Open
turegjorup wants to merge 4 commits into
Open
turegjorup wants to merge 4 commits into
turegjorup wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python template's dev image gets its test and lint tools, and they are reachable when the workflows run them in a service with the template's
./:/appbind mount.Changes
templates/python/pyproject.toml: dev tools in[dependency-groups] devinstead of[project.optional-dependencies] devtemplates/python/Dockerfile:UV_PROJECT_ENVIRONMENT=/opt/venvand/opt/venv/binonPATH;/opt/venvcreated and owned byappWhy
uv syncinstalls thedevdependency group by default and skips it with--no-dev, but installs optional extras only with--extra dev. With an extra, the dev target had nopytest,rufforbasedpyright.uv synccreates the venv in/app/.venv, which the./:/appbind mount indocker-compose.ymlhides, and nothing put.venv/binonPATH. The workflows callpytest --cov,ruffandbasedpyrightdirectly, so both failed with "executable file not found in $PATH"./opt/venvis the setup AarhusAI/automated-tests already uses for the same reason. search-agent, where the Dockerfile comes from, avoids the problem by mounting only./srcand./testsand calling tools throughuv run.Tested in AarhusAI/aarhusai-audit, which applies the template with these two changes:
ruff check,ruff format --check,basedpyright,uv lock --checkandpytest --covpass in the labelled service. The template itself does not build as-is (placeholders, nosrc/).