Skip to content

[VPP] Fix VAAPI buffer leak on close - #389

Closed
fjdoria76 wants to merge 1 commit into
intel:mainfrom
fjdoria76:fjdoria76-fix-memory-leak-vpl-gpu-runtime
Closed

fjdoria76 wants to merge 1 commit into
intel:mainfrom
fjdoria76:fjdoria76-fix-memory-leak-vpl-gpu-runtime

Conversation

@fjdoria76

Copy link
Copy Markdown

VPP pipeline parameter buffers can remain allocated when processing exits before the normal per-frame cleanup. This change destroys any outstanding pipeline buffers during VAAPI VPP teardown and resets the related filter and cached state for safe reinitialization.

git diff --check passes. Runtime compilation could not be completed on the macOS host because va/va_version.h is unavailable.

Fixes: #368

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@fjdoria76
fjdoria76 marked this pull request as draft September 30, 2026 10:40
@fjdoria76 fjdoria76 closed this Sep 30, 2026
@fjdoria76

Copy link
Copy Markdown
Author

Agreed. I reviewed the final diff and the existing Close() cleanup fully addresses the outstanding VA pipeline buffer leak, so no additional code changes are needed.

@fjdoria76

Copy link
Copy Markdown
Author

Agreed - the final change in VAAPIVideoProcessing::Close() destroys outstanding pipeline parameter buffers. This confirmation matches the diff, and no further code change is warranted.

@fjdoria76

Copy link
Copy Markdown
Author

Confirmed: the existing teardown path releases the outstanding VA buffers and resets their associated state. I found no remaining gap that calls for another patch.

@fjdoria76

Copy link
Copy Markdown
Author

I agree with this assessment. The final diff cleans up each remaining pipeline buffer before clearing the IDs and cached state, so additional edits are unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Memory leak on VPL GPU Runtime 2025Q1 Release - 25.1.4

1 participant