Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
fjdoria76
marked this pull request as draft
September 30, 2026 10:40
Author
|
Agreed. I reviewed the final diff and the existing Close() cleanup fully addresses the outstanding VA pipeline buffer leak, so no additional code changes are needed. |
Author
|
Agreed - the final change in VAAPIVideoProcessing::Close() destroys outstanding pipeline parameter buffers. This confirmation matches the diff, and no further code change is warranted. |
Author
|
Confirmed: the existing teardown path releases the outstanding VA buffers and resets their associated state. I found no remaining gap that calls for another patch. |
Author
|
I agree with this assessment. The final diff cleans up each remaining pipeline buffer before clearing the IDs and cached state, so additional edits are unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VPP pipeline parameter buffers can remain allocated when processing exits before the normal per-frame cleanup. This change destroys any outstanding pipeline buffers during VAAPI VPP teardown and resets the related filter and cached state for safe reinitialization.
git diff --checkpasses. Runtime compilation could not be completed on the macOS host becauseva/va_version.his unavailable.Fixes: #368