Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/callback-api #560 +/- ##
=========================================================
+ Coverage 92.04% 92.05% +0.01%
=========================================================
Files 54 54
Lines 10900 10914 +14
Branches 1407 1407
=========================================================
+ Hits 10033 10047 +14
Misses 579 579
Partials 288 288
🚀 New features to boost your workflow:
|
ikalchev
force-pushed
the
refactor/hap-status-error
branch
from
November 13, 2026 13:02
ddf1d1d to
059c3f8
Compare
ikalchev
changed the base branch from
docs/callback-refactor-design
to
refactor/callback-api
November 13, 2026 13:03
ikalchev
commented
Nov 13, 2026
| per-connection state from leaking to a reused client address. The driver | ||
| does not dispatch them yet; the write and read pipelines adopt them in the | ||
| following releases of the refactor. | ||
| - Callbacks can answer a HAP status instead of the generic -70402: a setter |
Owner
Author
There was a problem hiding this comment.
drop the changelog changes for now
Owner
Author
There was a problem hiding this comment.
Dropped — also from the third PR of the stack, so the changelog entries return with the finished design.
A setter that raises HapStatusError now answers the controller with its status instead of the generic -70402, at every callback level: a characteristic's setter answers for itself, a service or accessory setter for all of its characteristics in the request. A coroutine setter that raises it answers the same way once it is done, so a refusal is reported whether the callback is sync or async, and other characteristics of the request keep their own results. Closes #75 for characteristic, service and accessory level setters.
ikalchev
force-pushed
the
refactor/callback-api
branch
from
November 13, 2026 14:41
f902694 to
09c4c3a
Compare
ikalchev
force-pushed
the
refactor/hap-status-error
branch
from
November 13, 2026 14:41
059c3f8 to
df8cde0
Compare
Owner
Author
|
Closing per maintainer decision — continuing locally; the work continues on local branches and will return as PRs when the design settles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #562 (the callback interface APIs). Makes the driver's write path answer
HapStatusError, the first piece of the new interface to be dispatched.What
HapStatusErroranswers the controller with its status — sync and coroutine setters alike; other characteristics of the request keep their own results.-70402(unchanged).advanced/async.rstdocuments the protocol with an example.Closes #75 for characteristic, service and accessory level setters. The getter side follows in #561; the curated status set is defined by
pyhap.errors(reviewed in #562).