Repository navigation
Conversation
HannesVDB
added
enhancement
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Risk: M
Why this size?
The Sentry filter is wired into all four flavor entrypoints (
main,main_alpha,main_beta,main_prod) TheSentryEventFilteris registered inlib/di, and it decides which events reach Sentry in production.Therefore specific filter events are created. So we can determine if a background or foreground event is triggered. If an event matches one of the rules we can drop it. So it doesn't reach Sentry.
Where should the reviewer look, and what am I unsure about?
Most important files are in the
lib/utilsentry/-folder.This was tested in Blue-bike and was shown succesfull.
2. What changed and why
Jira: OSS-381: #381
Sentry is cluttered with a lot of events that we do not need. Therefore we created a filter.
3. Evidence: Flow / Proof of Delivery
See test scenarios
Edge cases tested (M and L):
No edge cases
Tested on (M and L): Simulator and temporariy crash.
Does anything deviate from the ticket? No