Repository navigation
Conversation
Every vehicle marker is tappable now, not only the ones whose trip is on the current stop's board. A vehicle on the board opens its departure's journey as before; any other opens the same trip view without "your stop": its timetable anchored to the service day it runs in, positioned from its latest map fix until the trip's own vehicle poll answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S7UaeZr3GF6pEcVuKGMvNV
|
🚀 Preview deployed: https://preview-71.tablo.run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ilnur · project thread
What
Every vehicle on the map is tappable now and opens the existing trip view. Before, only vehicles whose trip was on the current stop's board (the coloured ones) reacted to a tap.
How
Journey.mineandJourney.departureare optional;Journeycarries its ownrouteandkind. NewisAtMinereplaces the scatteredatStop && seg == minechecks.JourneyBuilder.build(plan:route:kind:vehicle:now:)builds a journey with no departure. Without a departure to anchor the timetable,serviceDaypicks Prague midnight of today or yesterday (for trips running past 24:00), whichever the timetable lies nearest. The shared placement and timing code moved intoassemble.FollowkeepstripId,routeandkinditself, with an optionaldeparture.StopModel.openVehiclestarts from the vehicle's latest map fix, so the view places it right away, until the trip's own vehicle poll answers.Testing
JourneyTestsfor the service day and the departure-less journey.Known: a vehicle passing right over a platform pin can lose the tap to the platform. Left as is.
Generated by Claude Code