Skip to content

feat(ios): tap any vehicle on the map to follow its trip - #71

Open
i11v wants to merge 1 commit into
mainfrom
feat/ios-tap-any-vehicle
Open

i11v wants to merge 1 commit into
mainfrom
feat/ios-tap-any-vehicle

Conversation

@i11v

@i11v i11v commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Requested by Ilnur · project thread

What

Every vehicle on the map is tappable now and opens the existing trip view. Before, only vehicles whose trip was on the current stop's board (the coloured ones) reacted to a tap.

  • On the board (coloured): opens that departure's journey, exactly as tapping its board row does.
  • Not on the board (grey): opens the same trip view without "your stop": route chip, TOWARDS headsign, no countdown, summary "N stops to , HH:MM", the stop list with the NOW row, and the route on the map.

How

  • Journey.mine and Journey.departure are optional; Journey carries its own route and kind. New isAtMine replaces the scattered atStop && seg == mine checks.
  • JourneyBuilder.build(plan:route:kind:vehicle:now:) builds a journey with no departure. Without a departure to anchor the timetable, serviceDay picks Prague midnight of today or yesterday (for trips running past 24:00), whichever the timetable lies nearest. The shared placement and timing code moved into assemble.
  • Follow keeps tripId, route and kind itself, with an optional departure. StopModel.openVehicle starts from the vehicle's latest map fix, so the view places it right away, until the trip's own vehicle poll answers.
  • Map: all vehicle markers are tappable; the "your stop" marker and overlay skip a journey without one.

Testing

  • Built and ran the full suite on the iPhone 17 simulator: 95 tests pass, including new JourneyTests for the service day and the departure-less journey.
  • In the simulator: tapped grey bus 135 → trip view with "16 stops to Chodov, 21:09", past stops greyed, NOW "Between Krymská and Slovinská", route drawn. Tapped coloured tram 22 → usual journey with countdown and "Krymská · Your stop". Back returns to the board both times.

Known: a vehicle passing right over a platform pin can lose the tap to the platform. Left as is.


Generated by Claude Code

Every vehicle marker is tappable now, not only the ones whose trip is on
the current stop's board. A vehicle on the board opens its departure's
journey as before; any other opens the same trip view without "your
stop": its timetable anchored to the service day it runs in, positioned
from its latest map fix until the trip's own vehicle poll answers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S7UaeZr3GF6pEcVuKGMvNV
@i11v i11v self-assigned this Nov 20, 2026
@github-actions

Copy link
Copy Markdown

🚀 Preview deployed: https://preview-71.tablo.run
fallback: https://tablo-pr-71.i11v.workers.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants