Repository navigation
fix(ios): keep the locate button above the sheet when a platform is picked - #70
Merged
Merged
Conversation
…icked Picking a platform changed `activePlatform` and then animated the sheet up to 460 in the same turn. When a plain state change and an animated `sheetHeight` change land in one SwiftUI update, one of the two views that read `sheetHeight` (the locate button overlay or the sheet) can miss the animated change and stay at the old height until the next sheet change. The button then sat behind the sheet until the sheet was dragged. Size the sheet first in `selectPlatform` and `switchStop`, and note the rule on `setSheet`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S7UaeeDEqNxUmz8Y2r7bRL
The macOS runner image now has an iOS runtime whose key ends in a device
suffix ("-iPhone19"), so `tonumber` failed and no simulator was picked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S7UaeeDEqNxUmz8Y2r7bRL
|
🚀 Preview deployed: https://preview-70.tablo.run |
i11v
marked this pull request as ready for review
November 18, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ilnur · project thread
Before: picking a platform (tapping its pin on the map, sometimes its tab) with the sheet below 460pt raised the sheet, but the locate button vanished. It came back once the sheet was dragged.
After: the button stays 12pt above the sheet.
How:
selectPlatformsetactivePlatform(a plain change) and then calledsetSheet(460)(animated) in the same turn. When those meet in one SwiftUI update, one of the two views that readsheetHeight, the locate button overlay inStopCanvasorStopSheet, misses the animated change and stays at the old height until the next sheet change. Usually that's the button, left behind the sheet; sometimes the sheet stays put instead.selectPlatformand inswitchStop(which clearedsearchOpen/querybefore resizing).setSheetdocuments the rule.Checked in the iPhone 17 simulator (iOS 26.5) with frame logging and an in-app loop that lowers the sheet and selects a platform 60 times:
withAnimation: 0/60. Turning off the map side effects (setSelected,focusPlatform,layoutMargins) didn't help, so MapKit isn't involved.Not tried on a phone yet.
Also in this PR: the iOS workflow's "Pick an iPhone simulator" step failed on the current macOS runner image, because one iOS runtime key now ends in a device suffix (
-iPhone19) andjq'stonumberchoked on it. The step now parses only the leading version.https://claude.ai/code/session_01S7UaeeDEqNxUmz8Y2r7bRL
Generated by Claude Code