Skip to content

Add post type-aware taxonomy terms - #63

Closed
SenseAndImage wants to merge 2 commits into
humanmade:mainfrom
SenseAndImage:feature/filter-taxonomy-terms-by-post-type
Closed

SenseAndImage wants to merge 2 commits into
humanmade:mainfrom
SenseAndImage:feature/filter-taxonomy-terms-by-post-type

Conversation

@SenseAndImage

Copy link
Copy Markdown

Current Situation:
The taxonomy filter is already hiding empty terms by default. However hide_empty does not respect the currently choosen post_types(s) in the query loop block and just checks for absolute emptiness (term not assigned to ANY post or page). If you loop over the custom post type "books" and select the taxonomy "author" with the query-filter block you would see author terms that are not assigned to any books if the were assigned to another post type, like "essays". These terms will however yield not result the query loop block only shows book results.

This PR:
Adds an option to the "terms" section of the block settings that allows users to exclude terms that are not assigned to the currently selected post type.
image

@goldenapples

Copy link
Copy Markdown
Contributor

The hideEmpty attribute added in #69 should cover the same functionality as this branch. Closing as completed, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants